Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provisioning): Add node name to consolidation warning logs #1786

Closed
wants to merge 3 commits into from
Closed

feat(provisioning): Add node name to consolidation warning logs #1786

wants to merge 3 commits into from

Conversation

omerap12
Copy link
Member

Fixes aws/karpenter-provider-aws#7176

Description
Add Node Name in Pod getting evicted.
How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign ellistarn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from engedaam October 29, 2024 16:11
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jmdeal October 29, 2024 16:11
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11615483061

Details

  • 44 of 44 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 80.951%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 87.25%
Totals Coverage Status
Change from base Build 11603073442: 0.09%
Covered Lines: 8533
Relevant Lines: 10541
💛 - Coveralls

@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2024
@omerap12
Copy link
Member Author

PTAL @njtran

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2024
@engedaam
Copy link
Contributor

/assign @jmdeal

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2024
@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2024
@omerap12
Copy link
Member Author

omerap12 commented Jan 3, 2025

/remove lifecycle-stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2025
@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2025
@omerap12
Copy link
Member Author

omerap12 commented Feb 2, 2025

Sorry for pinging again.. just don't want that we will miss that out.
@engedaam
@jmdeal

@jonathan-innis
Copy link
Member

@omerap12 I think I'm a little confused by this change -- doesn't consolidationWarnings only get called for pending pods, how would this help for these pods? If they are pending (and aren't scheduled), then by definition they won't be attached to a node.

@jonathan-innis
Copy link
Member

/assign jonathan-innis

@omerap12
Copy link
Member Author

@omerap12 I think I'm a little confused by this change -- doesn't consolidationWarnings only get called for pending pods, how would this help for these pods? If they are pending (and aren't scheduled), then by definition they won't be attached to a node.

Yes, you are right. probably misunderstanding on my side. thanks for the review :)
/close

@k8s-ci-robot
Copy link
Contributor

@omerap12: Closed this PR.

In response to this:

@omerap12 I think I'm a little confused by this change -- doesn't consolidationWarnings only get called for pending pods, how would this help for these pods? If they are pending (and aren't scheduled), then by definition they won't be attached to a node.

Yes, you are right. probably misunderstanding on my side. thanks for the review :)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam Awaiting requested review from engedaam

@jmdeal jmdeal Awaiting requested review from jmdeal

Assignees

@jmdeal jmdeal

@jonathan-innis jonathan-innis

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Node Name in Pod getting evicted
6 participants
@omerap12 @k8s-ci-robot @coveralls @engedaam @jonathan-innis @jmdeal